Fix decoding of url-encoded relative paths - #86
Merged
Conversation
c3er
requested changes
Jul 29, 2026
c3er
left a comment
Owner
There was a problem hiding this comment.
Thank you for contribution!
I can confirm that it works as expected. Only the error handling could be a little improved. See my other comments
Contributor
Author
|
I just realized that you asked to log the entire |
Owner
|
Thank you for your contribution again!👍
Yes, it's better to just show all the available information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes navigation to local resources whose relative paths contain url-encoded characters (e.g. chinese filenames/directories).
Previously, relative paths were resolved without being decoded first, causing links such as
../证据/note.mdto fail after being url-encoded.Changes
mailto:, etc.).Tests
Added tests covering:
This fixes the reported issue with navigating to Markdown files whose paths contain non-ASCII characters while preserving existing behavior for web links.
Fixes #85