feat: add binding for wasi_config_set_stdin_bytes#245
Open
ramilmsh wants to merge 1 commit intobytecodealliance:mainfrom
Open
feat: add binding for wasi_config_set_stdin_bytes#245ramilmsh wants to merge 1 commit intobytecodealliance:mainfrom
ramilmsh wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Member
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think this'll want some tweaks ownership-wise though. The wasi_config_set_stdin_bytes API is defined as taking ownership of its vector argument. That means you'll want to construct the vector with wasm_byte_vec_new_uninitialized and then copy the bytes from Go into the allocated vector, then pass that vector off to the API. That'll avoid using Cbytes and free here I believe.
You can see an example here of passing byte arrays from Go into Rust, and you can use wasm_byte_vec_copy to copy from Go into the Rust-allocated vector.
Also, would it be possible to write a test for this as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a binding for wasi_config_set_stdin_bytes
I've never worked with cgo before, so no idea if this is safe/free of memory leaks, but seems to have worked for me