feat: remove the UAT feature - #188
Merged
Merged
Conversation
UAT approval is dropped from Hive: the `uat_section`, `uat_status`, `uat_approved_by` and `uat_date` fields on Hive Task, the `approve_uat` and `reject_uat` document methods, the panel section clients acted on, the board badge and the activity-feed label. The `uat_*` columns stay on `tabHive Task` — Frappe does not drop a column when its field goes — so the old values remain readable in the database until someone chooses to drop them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AupF7Eoc6JnGv1gaiQY6G
Greptile SummaryThe PR removes the obsolete UAT workflow across the Hive Task schema, backend methods, project activity, task panel, boards, shared frontend types, and end-to-end coverage.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| bwh_hive/bwh_hive/doctype/hive_task/hive_task.json | Removes the four UAT metadata fields from the Hive Task DocType while retaining the remaining task schema. |
| bwh_hive/bwh_hive/doctype/hive_task/hive_task.py | Removes generated UAT field annotations and the approval and rejection document methods. |
| bwh_hive/bwh_hive/api.py | Stops surfacing UAT status changes in project activity results. |
| frontend/src/components/tasks/TaskPanel.vue | Removes the UAT status display, approval controls, document method bindings, and related state. |
| frontend/src/components/tasks/TaskBoardCard.vue | Removes UAT badges and their supporting prop and theme dependency from task cards. |
| frontend/src/pages/ProjectDetailPage.vue | Stops requesting UAT status and passing client-presence state through the project task board. |
| frontend/src/pages/TasksPage.vue | Stops requesting UAT status for the shared task workspace. |
| frontend/src/types.ts | Removes the UAT status vocabulary and UAT properties from the shared HiveTask type. |
| e2e/tests/client-experience.spec.ts | Removes the obsolete expectation that clients can approve UAT from a read-only task panel. |
| e2e/tests/app-switcher.spec.ts | Replaces a markup-coupled sidebar trigger locator with an accessible role-and-name locator. |
Reviews (2): Last reviewed commit: "fix: anchor the app-switcher spec on a r..." | Re-trigger Greptile
`data-slot="sidebar-header"` is a frappe-ui internal, which the no-markup-locators guard rejects. The header trigger carries the workspace title, so its role and name are enough. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AupF7Eoc6JnGv1gaiQY6G
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UAT approval is no longer part of how Hive works, but the fields, document methods, task-panel section and board badge were all still in place.
Solution
Removed it end to end:
uat_section,uat_status,uat_approved_by,uat_datefields and theapprove_uat/reject_uatwhitelisted methods.UAT <status>badge and theshowUat/hasClientprops that carried it from the project page down to the card.uat_statuschange label, anduat_statusfrom the surfaced-fields list.UAT_STATUSES,UATStatus,uatStatusThemeand the threeHiveTaskfields.client-experience.spec.ts.The
uat_*columns stay ontabHive Task— Frappe does not drop a column when its field is removed — so old values remain readable in the database. Say the word if you want a patch that drops them.Testing
bench migrate, frontendtypecheck,lintandbuildall clean. Playwright:client-experience,tasksandprojectsspecs, 21 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_014AupF7Eoc6JnGv1gaiQY6G