Repository navigation
refactor(events): drop link auto-suggest and keep http links as typed - #525
Merged
Merged
Conversation
The link dialog no longer guesses a label and icon from the URL; new links start on the generic link icon and organisers name them. Editing an existing http:// link saves it back as http:// instead of upgrading it to https://. The server-side URL check names the row instead of its label, since validate runs before the mandatory check and the label may still be empty.
harshtandiya
added
the
skip-demo
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Follow-up cleanup on event links from #524.
http://link no longer saves it back ashttps://.WebsiteInputstrips the scheme, so the dialog now remembers the original one.Row 2: link must start with…) instead of the label.validateruns before Frappe's mandatory check, so a missing label rendered as "Link None".fill()copies links with a spread instead of re-listing the three fields.Not changed:
submitOnEnterstays. The form has two inputs and no submit button, so Enter won't submit natively, and a submit-type Button fires twice (seeAddCoHostDialog).Demo
skip-demo: dialog looks the same; only the auto-filled label and icon are gone.Testing
bench run-tests --module buzz.api.events.test_events: 98 OKnode --test src/utils/eventLinks.test.ts: 4 passvue-tscclean forsrc/, pre-commit cleanmanage-event.spec.tslinks tests updated to type the label and pick the icon; left to CI