Skip to content

feat(dashboard): rename Guests sidebar item to Registrations #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshtandiya merged 1 commit into from
Oct 1, 2026
Merged

feat(dashboard): rename Guests sidebar item to Registrations #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/src/pages/manage/events/EventGuests.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ useIntersectionObserver(sentinel, ([entry]) => entry?.isIntersecting && loadMore
</script>

<template>
<EventPageHeader :title="page.data?.title" section="Guests" />
<EventPageHeader :title="page.data?.title" section="Registrations" />

<PageWithSidebar>
<EventArchivedAlert :event="eventId" />
Expand Down
2 changes: 1 addition & 1 deletion dashboard/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const routes: RouteRecordRaw[] = [
{
path: "events/:eventId/guests",
name: "event-guests",
meta: { title: "Guests" },
meta: { title: "Registrations" },
component: () => import("@/pages/manage/events/EventGuests.vue"),
},
{
Expand Down
2 changes: 1 addition & 1 deletion dashboard/src/utils/managerNavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function eventItems(eventId: string): ManagerNavItem[] {
const event = `/manage/events/${eventId}`
return [
{ label: "Details", icon: "lucide-receipt-text", to: `${event}/details` },
{ label: "Guests", icon: "lucide-users-round", to: `${event}/guests` },
{ label: "Registrations", icon: "lucide-users-round", to: `${event}/guests` },
{ label: "Talks", icon: "lucide-presentation", to: `${event}/talks` },
{
label: "Announcements",
Expand Down
10 changes: 5 additions & 5 deletions e2e/tests/manage-event.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ test.describe("Event workspace", () => {
})

test("swaps the sidebar for the event's own destinations", async ({ page }) => {
for (const label of ["Details", "Guests", "Talks"]) {
for (const label of ["Details", "Registrations", "Talks"]) {
await expect(page.getByRole("link", { name: label })).toBeVisible({ timeout: 15000 })
}
await expect(page.getByRole("button", { name: "Back to events" })).toBeVisible()
Expand Down Expand Up @@ -242,7 +242,7 @@ test.describe("Guest list", () => {
})

test("lists the event's guests", async ({ page }) => {
await page.getByRole("link", { name: "Guests" }).click()
await page.getByRole("link", { name: "Registrations" }).click()

await expect(page).toHaveURL(new RegExp(`/b/manage/events/${eventId}/guests$`))
await expect(page.getByRole("heading", { name: "Guest list" })).toBeVisible()
Expand Down Expand Up @@ -325,7 +325,7 @@ test.describe("Unsaved details", () => {
// Save showing is the form registering the edit, so the trip below starts dirty.
await expect(page.getByRole("button", { name: "Save" })).toBeVisible()

await page.getByRole("link", { name: "Guests" }).click()
await page.getByRole("link", { name: "Registrations" }).click()
await expect(page).toHaveURL(new RegExp(`/b/manage/events/${eventId}/guests$`))
await page.getByRole("link", { name: "Details" }).click()

Expand All @@ -337,7 +337,7 @@ test.describe("Unsaved details", () => {
await page.getByRole("button", { name: "Discard" }).click()
await expect(description).toHaveValue("")

await page.getByRole("link", { name: "Guests" }).click()
await page.getByRole("link", { name: "Registrations" }).click()
await expect(page).toHaveURL(new RegExp(`/b/manage/events/${eventId}/guests$`))
await page.getByRole("link", { name: "Details" }).click()

Expand Down Expand Up @@ -376,7 +376,7 @@ test.describe("Unsaved details", () => {
await page.getByRole("button", { name: "Save" }).click()
await expect(page.getByText("Event saved")).toBeVisible()

await page.getByRole("link", { name: "Guests" }).click()
await page.getByRole("link", { name: "Registrations" }).click()
await expect(page).toHaveURL(new RegExp(`/b/manage/events/${eventId}/guests$`))
await page.getByRole("link", { name: "Details" }).click()

Expand Down
4 changes: 2 additions & 2 deletions e2e/tests/page-titles.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ test.describe("Page titles", () => {
const title = await field.inputValue()

await expect(page).toHaveTitle(`Details | ${title}`)
await page.getByRole("link", { name: "Guests" }).click()
await expect(page).toHaveTitle(`Guests | ${title}`)
await page.getByRole("link", { name: "Registrations" }).click()
await expect(page).toHaveTitle(`Registrations | ${title}`)
})

test("keeps a data-derived title, and drops it on the way out", async ({ page }) => {
Expand Down
Loading