Skip to content

feat(check-in): link ticket ID to its desk record - #366

Merged
harshtandiya merged 1 commit into
developfrom
feat/checkin-desk-link
Aug 19, 2026
Merged

feat(check-in): link ticket ID to its desk record#366
harshtandiya merged 1 commit into
developfrom
feat/checkin-desk-link

Conversation

@harshtandiya

@harshtandiya harshtandiya commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

What changed

Front-desk staff scanning at /b/check-in had to copy the ticket ID out of the
validation dialog and navigate to Desk by hand to inspect a ticket mid-queue.
The Ticket ID in TicketDetailsModal.vue is now an anchor to
/app/event-ticket/<id> in a new tab, with an external-link icon. Same pattern
as the Zoom link in TicketDetails.vue.

Presentation-only — the id is already in the CheckinResponse payload, and the
modal serves both pre- and post-check-in states, so one edit covers both.

No role gate on the link: the page is already Frontdesk Manager-only, and a
user without Desk access lands on Frappe's own permission screen. Add a guard
later if that confuses staff.

Demo

skip-demo — nine lines of template, no Chrome available to capture locally.

Testing

No test; prettier and vue-tsc --noEmit clean. Not clicked through in a browser
locally (no Chrome for the automation here) — worth eyeballing that the link
lands on the right record.

🤖 Generated with Claude Code

Front-desk staff had to copy the ticket ID out of the check-in dialog and
navigate to Desk by hand to inspect a ticket mid-queue. The ID now opens
/app/event-ticket/<id> in a new tab.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@harshtandiya harshtandiya added backport main backport to main branch skip-demo Skip adding a video / screenshot in PR description. Passes the failing CI for demo addition labels Aug 19, 2026
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes the check-in modal’s Ticket ID clickable so front-desk staff can open the corresponding Event Ticket record in a new Desk tab.

  • Replaces the plain Ticket ID text with a same-origin Desk anchor.
  • Adds an external-link icon and appropriate new-tab security attributes.

Confidence Score: 5/5

The PR appears safe to merge; the link uses the validated Event Ticket document name and the canonical Desk route.

The successful check-in response always supplies the Event Ticket document name as the ticket ID, and the new anchor maps that value to the expected /app/event-ticket/<name> route while retaining safe new-tab attributes.

Important Files Changed

Filename Overview
dashboard/src/components/TicketDetailsModal.vue Correctly links the validated Event Ticket document name to its canonical Frappe Desk route without changing check-in behavior.

Reviews (1): Last reviewed commit: "feat(check-in): link ticket ID to its de..." | Re-trigger Greptile

@harshtandiya
harshtandiya merged commit 37f16dc into develop Aug 19, 2026
13 of 14 checks passed
@harshtandiya
harshtandiya deleted the feat/checkin-desk-link branch August 19, 2026 11:55
@github-actions

Copy link
Copy Markdown
Contributor

Successfully created backport PR for main:

harshtandiya added a commit that referenced this pull request Aug 19, 2026
feat(check-in): link ticket ID to its desk record (#366)

Front-desk staff had to copy the ticket ID out of the check-in dialog and
navigate to Desk by hand to inspect a ticket mid-queue. The ID now opens
/app/event-ticket/<id> in a new tab.


(cherry picked from commit 37f16dc)

Co-authored-by: Harsh Tandiya <harsh.tandiya@gmail.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport main backport to main branch skip-demo Skip adding a video / screenshot in PR description. Passes the failing CI for demo addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant