Skip to content

feat(dashboard): a team's events at /manage/team/events - #353

Merged
harshtandiya merged 1 commit into
developfrom
version-2-dashboard-team-events
Aug 19, 2026
Merged

feat(dashboard): a team's events at /manage/team/events#353
harshtandiya merged 1 commit into
developfrom
version-2-dashboard-team-events

Conversation

@harshtandiya

@harshtandiya harshtandiya commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

What changed

Fifth in the /manage stack. #352 has merged, so this sits directly on develop.
The team dashboard could show its members but not its events. This fills in a new
Team > Events sidebar item at /manage/team/events.

  • /manage/team/eventsTeamPageHeader over the same TimelineList and
    Upcoming/Past toggle the personal Events page already uses.
  • No new endpoint. get_my_events already returns every event the user's teams
    host, each row carrying its team. Filtering that feed by currentTeam is the
    team's whole calendar.
  • A Manage button on EventCard. Two gates: the caller has to want it
    (showManage, default true) and the event has to be one the user hosts
    (is_host). The team page passes false — every row there belongs to the team,
    so a per-card button says nothing.
  • Sidebar trimmed. Team's Registrations, Sponsors and More were placeholders for
    pages that are not planned. The personal item becomes "My Events" to tell it apart
    from the team's, and Overview's "See all events" now lands on the team page.

Worth knowing

The Manage button goes nowhere yet. It renders and does nothing — #354/#355 land
the event workspace behind it. Marked with a TODO rather than held back, so the card
layout lands once.

Team scope stays ambient. The route is the fixed /manage/team/events, not
/manage/<team>/events; the page reads currentTeam like every other team page in
this stack.

manage-access.spec.ts clicks Sponsorship now. It used Registrations to reach
the work-in-progress placeholder, and that sidebar item is gone.

Not in scope

No e2e spec for the new route — asserting the team filter needs a second seeded team
and auth.setup.ts seeds one. MyTickets.vue and MyProposals.vue still declare
their own tab options.

Demo

image

Testing

pre-commit clean on all 8 files, yarn typecheck clean, 70 unit tests, yarn build
clean. Playwright was green on the pre-rebase head.

Rebased onto develop after #352 squash-merged: the four #352 commits dropped, one
commit left. The only content change is a prettier reflow of the filter callback in
TeamEvents.vue, folded in — it was the Frappe Linter red.

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a team events timeline that reuses the personal events feed, filters it to the active team, and integrates the page into team navigation.

  • Adds the /manage/team/events route and team sidebar entry.
  • Extracts configurable event-card management visibility for reuse on the team timeline.
  • Updates team overview navigation, personal-event labels, styling, and the placeholder-route E2E assertion.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
dashboard/src/pages/manage/teams/TeamEvents.vue Adds the team-filtered upcoming/past event timeline using the existing events resource and shared timeline components.
dashboard/src/components/dashboard/events/EventCard.vue Adds an optional host-only Manage button while allowing team timelines to suppress it.
dashboard/src/layouts/ManagerLayout.vue Adds team-events navigation, distinguishes personal events by label, and removes unused placeholder links.
dashboard/src/router.ts Registers the fixed /manage/team/events child route.
dashboard/src/pages/manage/teams/TeamOverview.vue Redirects the overview’s event-list action to the new team events route.
e2e/tests/manage-access.spec.ts Updates placeholder navigation coverage to use the remaining Sponsorship item.

Reviews (6): Last reviewed commit: "feat(dashboard): a team's events at /man..." | Re-trigger Greptile

Comment thread dashboard/src/components/TeamSwitcher.vue Outdated
@NagariaHussain

Copy link
Copy Markdown
Contributor

I don't think, URL based team page is a good idea. Check how frappe/central does it.

@harshtandiya
harshtandiya force-pushed the version-2-dashboard-team-members branch from ce31578 to a58f3ab Compare August 17, 2026 10:44
@harshtandiya
harshtandiya force-pushed the version-2-dashboard-team-events branch 2 times, most recently from ff14afc to b23702f Compare August 17, 2026 13:30
@harshtandiya
harshtandiya force-pushed the version-2-dashboard-team-members branch 2 times, most recently from c6ad7db to 4ca3238 Compare August 19, 2026 06:14
@harshtandiya
harshtandiya force-pushed the version-2-dashboard-team-events branch from b23702f to 5ec7c74 Compare August 19, 2026 06:14
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

UI Demo Check — a screenshot or demo is attached.

@harshtandiya
harshtandiya force-pushed the version-2-dashboard-team-events branch from 5ec7c74 to 94f451c Compare August 19, 2026 07:20
@harshtandiya
harshtandiya force-pushed the version-2-dashboard-team-members branch 2 times, most recently from 5ec71cd to 86ae417 Compare August 19, 2026 09:04
Base automatically changed from version-2-dashboard-team-members to develop August 19, 2026 14:12
The team dashboard could show its members but not its events, so the sidebar's
"See all events" and the Overview preview both led to the personal feed. This
adds the team's own timeline, reached from a new Team > Events sidebar item,
and points the Overview link at it.

Every event on the page belongs to the team, so the per-card Manage button
carries no information here — EventCard takes a `showManage` prop to switch it
off. The rows come from the events feed the personal page already loads,
filtered by team: a member sees every event their team hosts, so no new
endpoint is needed.

Registrations, Sponsors and More leave the sidebar. They were placeholders for
pages that are not planned. Renames the personal item to "My Events" to tell it
apart from the team's.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@harshtandiya
harshtandiya force-pushed the version-2-dashboard-team-events branch from 94f451c to 3a81380 Compare August 19, 2026 14:17
@harshtandiya harshtandiya changed the title feat(dashboard): a team's events at /manage/<team>/events feat(dashboard): a team's events at /manage/team/events Aug 19, 2026
@harshtandiya

Copy link
Copy Markdown
Collaborator Author

@NagariaHussain that was refactored in #351

@harshtandiya
harshtandiya merged commit 6266f84 into develop Aug 19, 2026
11 of 13 checks passed
@harshtandiya
harshtandiya deleted the version-2-dashboard-team-events branch August 19, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants