feat(dashboard): a team's events at /manage/team/events - #353
Merged
Conversation
Contributor
Greptile SummaryAdds a team events timeline that reuses the personal events feed, filters it to the active team, and integrates the page into team navigation.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| dashboard/src/pages/manage/teams/TeamEvents.vue | Adds the team-filtered upcoming/past event timeline using the existing events resource and shared timeline components. |
| dashboard/src/components/dashboard/events/EventCard.vue | Adds an optional host-only Manage button while allowing team timelines to suppress it. |
| dashboard/src/layouts/ManagerLayout.vue | Adds team-events navigation, distinguishes personal events by label, and removes unused placeholder links. |
| dashboard/src/router.ts | Registers the fixed /manage/team/events child route. |
| dashboard/src/pages/manage/teams/TeamOverview.vue | Redirects the overview’s event-list action to the new team events route. |
| e2e/tests/manage-access.spec.ts | Updates placeholder navigation coverage to use the remaining Sponsorship item. |
Reviews (6): Last reviewed commit: "feat(dashboard): a team's events at /man..." | Re-trigger Greptile
Contributor
|
I don't think, URL based team page is a good idea. Check how frappe/central does it. |
harshtandiya
force-pushed
the
version-2-dashboard-team-members
branch
from
August 17, 2026 10:44
ce31578 to
a58f3ab
Compare
harshtandiya
force-pushed
the
version-2-dashboard-team-events
branch
2 times, most recently
from
August 17, 2026 13:30
ff14afc to
b23702f
Compare
harshtandiya
force-pushed
the
version-2-dashboard-team-members
branch
2 times, most recently
from
August 19, 2026 06:14
c6ad7db to
4ca3238
Compare
harshtandiya
force-pushed
the
version-2-dashboard-team-events
branch
from
August 19, 2026 06:14
b23702f to
5ec7c74
Compare
Contributor
|
✅ UI Demo Check — a screenshot or demo is attached. |
harshtandiya
force-pushed
the
version-2-dashboard-team-events
branch
from
August 19, 2026 07:20
5ec7c74 to
94f451c
Compare
harshtandiya
force-pushed
the
version-2-dashboard-team-members
branch
2 times, most recently
from
August 19, 2026 09:04
5ec71cd to
86ae417
Compare
The team dashboard could show its members but not its events, so the sidebar's "See all events" and the Overview preview both led to the personal feed. This adds the team's own timeline, reached from a new Team > Events sidebar item, and points the Overview link at it. Every event on the page belongs to the team, so the per-card Manage button carries no information here — EventCard takes a `showManage` prop to switch it off. The rows come from the events feed the personal page already loads, filtered by team: a member sees every event their team hosts, so no new endpoint is needed. Registrations, Sponsors and More leave the sidebar. They were placeholders for pages that are not planned. Renames the personal item to "My Events" to tell it apart from the team's. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
harshtandiya
force-pushed
the
version-2-dashboard-team-events
branch
from
August 19, 2026 14:17
94f451c to
3a81380
Compare
Collaborator
Author
|
@NagariaHussain that was refactored in #351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fifth in the
/managestack. #352 has merged, so this sits directly ondevelop.The team dashboard could show its members but not its events. This fills in a new
Team > Events sidebar item at
/manage/team/events./manage/team/events—TeamPageHeaderover the sameTimelineListandUpcoming/Past toggle the personal Events page already uses.
get_my_eventsalready returns every event the user's teamshost, each row carrying its
team. Filtering that feed bycurrentTeamis theteam's whole calendar.
EventCard. Two gates: the caller has to want it(
showManage, defaulttrue) and the event has to be one the user hosts(
is_host). The team page passesfalse— every row there belongs to the team,so a per-card button says nothing.
pages that are not planned. The personal item becomes "My Events" to tell it apart
from the team's, and Overview's "See all events" now lands on the team page.
Worth knowing
The Manage button goes nowhere yet. It renders and does nothing — #354/#355 land
the event workspace behind it. Marked with a TODO rather than held back, so the card
layout lands once.
Team scope stays ambient. The route is the fixed
/manage/team/events, not/manage/<team>/events; the page readscurrentTeamlike every other team page inthis stack.
manage-access.spec.tsclicks Sponsorship now. It used Registrations to reachthe work-in-progress placeholder, and that sidebar item is gone.
Not in scope
No e2e spec for the new route — asserting the team filter needs a second seeded team
and
auth.setup.tsseeds one.MyTickets.vueandMyProposals.vuestill declaretheir own tab options.
Demo
Testing
pre-commitclean on all 8 files,yarn typecheckclean, 70 unit tests,yarn buildclean. Playwright was green on the pre-rebase head.
Rebased onto
developafter #352 squash-merged: the four #352 commits dropped, onecommit left. The only content change is a prettier reflow of the filter callback in
TeamEvents.vue, folded in — it was the Frappe Linter red.🤖 Generated with Claude Code