Fix #18: Add landing page with reusable UI components#28
Open
DjYash007 wants to merge 1 commit into
Open
Conversation
Implements LandingPage, PrimaryButton, and StudentCapsule components based on Figma designs. Includes decorative curl vectors, YDO logo, hero text, and CTA button with mobile-first layout. Closes bsoc-bitbyte#18
Collaborator
|
Great, I need a video of it working. Also sorry for the last minute changes, please make ur changes to the login page. For now until we dont have a proper landing page, reroute everything to login page. other than that lgtm. |
Collaborator
|
Also where are the system toasts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the landing page for YDO as per issue.
Three reusable components built:
PrimaryButton- accepts children, onClick, disabled, className propsStudentCapsule- static pill badge for IIITDMJ studentsLandingPage- mobile-first layout with YDO branding, hero text, CTA, and decorative curl vectorsFixes #18
Reviewer Guidance
Start with
components/ui/PrimaryButton.tsxandcomponents/ui/StudentCapsule.tsx-these are the two reusable components.
components/pages/LandingPage.tsxcomposes themDeliberate tradeoff:
Curls.svgusesabsolute inset-0positioning -this is intentional for the decorative background layer, not layout positioning.
Desktop curl scaling scoped out - vectors are designed for the 402px mobile viewport.
Can be addressed in a follow-up if required.
Note: mobile-web-app-capable in metadata was added for landscape orientation handling, can be removed if out of scope.
Essential Checklist
Fix #bugnum:, followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title withFix part of #bugnum: ....)mainormaster.Proof of Work
AI Usage Disclosure
Used Claude (Anthropic) as a development assistant for figma spec analysis, component architecture guidance.