Skip to content

Slasher #1041

Open
MrWad3r wants to merge 42 commits intofeature/slasherfrom
feature/slasher-session
Open

Slasher #1041
MrWad3r wants to merge 42 commits intofeature/slasherfrom
feature/slasher-session

Conversation

@MrWad3r
Copy link
Copy Markdown
Member

@MrWad3r MrWad3r commented Feb 26, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None] / [Yes]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None] / [Yes]


COMPATIBILITY

Affected features:

  • [State]
  • [State. Blockchain Config]
  • [Block]
  • [Block Proof]
  • [Archive]
  • [Persistent State]
  • [Persistent Queue]
  • [Storage. Blocks]
  • [Storage. States]
  • [Storage. Archives]
  • [Queue. Diff]
  • [Queue. Storage]
  • [Queue. Storage. Statistics]
  • [Message Processing Algorithm]
  • [ProcessedUpto]
  • [Collator. Limits]
  • [Collator. Work Units Calculation]
  • [Mempool. Consensus Config]
  • [Mempool. Validation rules]
  • [Mempool. Storage]
  • [Mempool. API tl models]

SPECIAL DEPLOYMENT ACTIONS

[Not Required] / [Required]


PERFORMANCE IMPACT

[No impact expected] / [Expected impact]


TESTS

Unit Tests

[Covered by:] / [No coverage]

Network Tests

[Covered by:] / [No coverage]

Manual Tests

[Manual tests used]

  • [1-255]
  • [transfers]
  • [swaps]

Notes/Additional Comments:

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1041

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1041
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1041 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 4.57921% with 771 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.20%. Comparing base (8f28798) to head (f86db80).

Files with missing lines Patch % Lines
slasher/src/storage/mod.rs 0.00% 286 Missing ⚠️
slasher/src/storage/models.rs 0.00% 188 Missing ⚠️
slasher/src/lib.rs 0.00% 103 Missing ⚠️
slasher/src/analyzer.rs 0.00% 99 Missing ⚠️
slasher/src/bc/mod.rs 0.00% 27 Missing ⚠️
slasher/src/storage/db.rs 0.00% 20 Missing ⚠️
slasher/src/util.rs 0.00% 12 Missing ⚠️
slasher/src/collector/validator_events.rs 0.00% 10 Missing ⚠️
slasher/src/bc/stub_contract.rs 0.00% 9 Missing ⚠️
cli/src/cmd/tools/gen_zerostate.rs 0.00% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/slasher    #1041      +/-   ##
===================================================
- Coverage            56.73%   56.20%   -0.54%     
===================================================
  Files                  441      442       +1     
  Lines                73969    74137     +168     
  Branches             73969    74137     +168     
===================================================
- Hits                 41969    41670     -299     
- Misses               29979    30467     +488     
+ Partials              2021     2000      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrWad3r MrWad3r force-pushed the feature/slasher-session branch 4 times, most recently from 1780cf0 to e426d3b Compare March 16, 2026 15:18
@MrWad3r MrWad3r changed the base branch from feature/slasher to master March 18, 2026 11:18
@MrWad3r MrWad3r changed the title chore(core): change ValidationSessionId signature Slasher Mar 19, 2026
@MrWad3r MrWad3r changed the base branch from master to feature/slasher March 20, 2026 12:48
@Rexagon Rexagon force-pushed the feature/slasher-session branch from 4aa5c16 to d8eaca4 Compare March 20, 2026 13:31
@MrWad3r MrWad3r force-pushed the feature/slasher-session branch from d8eaca4 to 9c6ad3d Compare March 24, 2026 10:59
@MrWad3r MrWad3r requested a review from Rexagon March 24, 2026 11:07
@MrWad3r MrWad3r marked this pull request as ready for review March 24, 2026 11:07
@MrWad3r MrWad3r force-pushed the feature/slasher-session branch from 9c6ad3d to 5c88251 Compare March 24, 2026 11:19
@MrWad3r MrWad3r marked this pull request as draft March 25, 2026 04:17
@MrWad3r MrWad3r force-pushed the feature/slasher-session branch from 4dcbf34 to e626422 Compare March 30, 2026 12:31
@MrWad3r MrWad3r marked this pull request as ready for review March 31, 2026 10:17
@MrWad3r MrWad3r requested a review from 0xdeafbeef March 31, 2026 10:17
@MrWad3r MrWad3r force-pushed the feature/slasher-session branch from e626422 to f86db80 Compare April 9, 2026 10:54
@MrWad3r MrWad3r force-pushed the feature/slasher-session branch from f86db80 to 8542d1f Compare April 9, 2026 12:46
pub fn compute_standard(
validator_set: &ValidatorSet,
cc_seqno: u32,
vset_switch_round: u32,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: better to rename to switch_round, because the switch round applies not only to the set but also to the subset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants