fix(base-foundation, base-io): add toString() to Exceptional and PathSet - #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptionalhad notoString()override, so instances printed the defaultObjectidentity hash instead of anything useful for debugging or logging; this adds atoString()that rendersExceptional[value],Exceptional[exception], orExceptional.emptydepending on which of the three states the instance is in, matching the same three-way branching already used byequals()andhashCode().PathSet's empty singleton previously rendered as the string"PathSet.empty()", which reads like a factory-method reference rather than a value representation and doesn't match how a populatedPathSetprints. This adds atoString()to the internal non-emptyPathSetBuilderimplementation that delegates to the underlyingLinkedHashSet<Path>, and changesPathSet.empty()'stoString()from"PathSet.empty()"to"[]"so both the empty and non-empty cases render consistently with each other and with standardSetformatting.