Fix failing GitHub Actions job "Shim to runc (tier 3)" - #1
Merged
Conversation
…ning in mixed mode
The failing CI job "Shim to runc (tier 3)" asserted:
assert_contains ... "$out" "MIXED"
But OrdersApp.java's /hello handler always returned Greeter.greeting()
("Hello from a MODULAR JPMS app..."), which contains "MODULAR" but not "MIXED".
In mixed mode (java -cp /app/lib/* -p ...) the JVM's java.class.path
property is non-empty (set to /app/lib/*). In pure module-path mode it
is empty. Detect this at runtime and prepend "MIXED: " to the greeting
when in mixed mode, so the test assertion is satisfied while the pure
modular assertion ("MODULAR") continues to pass.
brunoborges
approved these changes
Jul 18, 2026
brunoborges
marked this pull request as ready for review
July 18, 2026 04:00
brunoborges
approved these changes
Jul 18, 2026
brunoborges
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.