ci: harden the npm publish script (#329)#341
Open
BROGOTSOME wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
Description
This PR addresses the security risks outlined in #329 regarding the exposure of environment secrets during the dependency installation phase of the scheduled auto-release.yml workflow.
Previously, COINGECKO_API_KEY and API_AUTH_TOKEN_GITHUB were declared at the top-level env block. Because this workflow runs on a daily cron schedule (0 1 * * *) and executes pnpm start (which can trigger install hooks), a compromised transitive dependency could potentially run malicious scripts and silently exfiltrate these broadly scoped secrets.
Changes Made
Scoped Environment Secrets: Removed the global env block and moved COINGECKO_API_KEY and API_AUTH_TOKEN_GITHUB directly into the Build assets step. This restricts secret access strictly to the step that requires them.
Disabled Install Scripts: Added the --ignore-scripts flag to the pnpm install --frozen-lockfile step to prevent the execution of arbitrary scripts from dependencies during the setup phase.
So Impact would be
These changes mitigate the highest-risk finding in the repository by ensuring secrets are isolated from the dependency installation and build setup phases, protecting the automated nightly runs from unauthorized secret exfiltration.