Add documentation for regional-list-specific fields#58
Open
antonok-edm wants to merge 1 commit into
Open
Conversation
Collaborator
|
We could add details on how the keys are generated just for docs (the exact command lines), saves me going through Slack history to remind myself . Happy to add that as a 2nd PR if it's easier. |
Collaborator
|
I think thats a great idea @ryanbr and @antonok-edm . Let me know if you need anything from me |
pes10k
approved these changes
Jan 31, 2022
Contributor
|
Needs rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #56, I figured it would be good to add more information to the README to hopefully avoid similar confusion in the future.
One thing that feels glaringly missing here is more information about how to generate
component_idandbase64_public_key. I recall there was some detail about adding the corresponding private key to 1password and asking devops to add it to the CRX packager pipeline as well. @pes10k @ryanbr do you have any more context that could be added here?