feat(render_agent_index): honor per-source evidence_id - #41
Merged
Conversation
Custom-merged dossiers (the P5 VLM gathers) carry ledger evidence_ids
that predate the computed ev_{topic}_{n} convention, and the display
validator resolves the printed Evidence-bullet id against
evidence_ledger.yml — so rendered output could never pass the display
gate for those dossiers.
- sources.json entries may carry evidence_id; the renderer prints it
when present; computed fallback unchanged (existing dossiers
unaffected)
- regression test: explicit id wins, fallback intact
Generated with Claude Code
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014jpLr4doRxvoh6eBrpGavX
One applied (the render_agent_index evidence_id coupling, fixed in f821cac) and three surfaced environment facts from the five-gather run: playwright/ubuntu26.04 escalation, arXiv /abs/ abstract-only extraction, ugrep long-regex limits. Generated with Claude Code Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014jpLr4doRxvoh6eBrpGavX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The renderer's Evidence bullet was a computed
ev_{topic}_{n}, andvalidators/agent_index_display.pyresolves the printed id againstevidence_ledger.yml(its Linkage-2 fallback cannot resolve rendered output — the manifest selections carry nofamily/bibkey/evidence_id). Dossiers whose ledgers were merged outsideassemble_artifacts.py— the five P5 VLM gathers, with ids likeev_vcf_a1_001— could therefore never pass the display gate.sources.jsonentries may now carryevidence_id; the renderer prints it when present. The computed fallback is unchanged, so the 24 existing systems dossiers are unaffected.Tests
test_render_evidence_bullet_honors_explicit_evidence_id— explicit id wins, fallback intact for sources without oneAlso files four P5 burn-in findings (one applied = this fix; three surfaced environment facts).
🤖 Generated with Claude Code
https://claude.ai/code/session_014jpLr4doRxvoh6eBrpGavX