Conversation
ee8a8af to
d3c9d48
Compare
|
Force-pushed to drop commits from other PR I accidentally included. |
|
@brainrom Could I please get your opinion on this? |
brainrom
left a comment
brainrom
left a comment
There was a problem hiding this comment.
A lot of meaningless and confusing variable/methods renames, one mpv keyword is broken.
program_arg is over-engineering, which greatly limits class usage scope.
New URL converter is really needed and maybe will allow to accept URLs without any other changes.
| parser.addHelpOption(); | ||
| parser.addVersionOption(); | ||
| parser.addPositionalArgument("media", QCoreApplication::translate("KokoVP", "Media files to play")); | ||
| parser.addPositionalArgument("urls", QCoreApplication::translate("KokoVP", "URLs to play")); |
There was a problem hiding this comment.
How multiple position arguments lists should work at all? Maybe just accept media by local file paths and by urls?
There was a problem hiding this comment.
May you please elaborate on this? I don't understand what you mean by this.
There was a problem hiding this comment.
Looks really useful for achieving accepting URLs. Needs testing and fixing mentioned issue, but anyway.
927e282 to
a4fc913
Compare
This makes it possible to use smtube with kokovp instead of smplayer.
To be squashed.
If something is already currently playing on the existing instance, the media gets added to the playlist, like before. If nothing is playing, start playback of the added media.
a4fc913 to
21936c7
Compare
To be squashed.
f985537 to
5f4f1fa
Compare
2 participants
I've not renamed the vars with file in it in all files as I want your opinion on that 1st. I settled for
mediaUrlandmediaRessource, to make it more obvious that it may also be a stream and "medium" sounded more too much like esoteric magic.Spaces in URLs don't work yet.