Skip to content

fix(docker): Add support for Docker 4.x #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sondrebjarkum wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(docker): Add support for Docker 4.x #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a39a41
chore(sqlserver): Update docker compose to use sqlserver instead of a…
sondrebjarkum Jun 6, 2025
34d24cb
fix(db import): Fixes auto importing db after running opti db command…
sondrebjarkum Jun 6, 2025
35c5420
fix(watch command): Temporarily disable ensureDbIsRunning
sondrebjarkum Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commands/db.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ async function handleDBCommandOptions(options) {
}

if (!options.name) {
options.name = `sqledge-${options.port}`;
options.name = `sqlserver-${options.port}`;
}
}

Expand Down
2 changes: 1 addition & 1 deletion commands/watch.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ program
.action(async () => {
await checkPrerequisites([checkDotnetExists]);

await ensureDbIsRunng();
// await ensureDbIsRunng();

const currentDir = process.cwd();
const fileName = 'launchSettings.json';
Expand Down
2 changes: 1 addition & 1 deletion helpers/docker.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function generateDBDockerCompose({ port, name }) {
# This file was generated using the opti cli tool
services:
sqledge:
image: mcr.microsoft.com/azure-sql-edge
image: mcr.microsoft.com/mssql/server:2025-latest
container_name: ${name}
environment:
- ACCEPT_EULA=1
Expand Down
2 changes: 1 addition & 1 deletion services/bacpac.service.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export async function importBacpac(
await runShellCommand('opti db up');
await waitForContainerLogString(
azuresqlContainerName,
'EdgeTelemetry starting up'
'Recovery is complete'
);
printer.success('Database started successfully!');
}
Expand Down