feat[close #4184]: add a sys-wine-current runner option so that the runner is not reset every system wine update#4187
Conversation
… that the runner is not reset every system wine update
|
Hi thanks for your contribution. Are you sure that single line is enough? |
|
Unfortunately my computer is having problems building flatpaks, so I can't test it for sure, but from a code standpoint I am pretty confident it will work. Based on what I saw, Bottles is currently just using janky code for system wine installations. The code only knows whether a runner is a system installation based on whether or not it starts with the prefix 'sys-'. Furthermore, the code to handles wine commands launches wine by setting the PATH environment variable to the location of the runner, but for the system installations it just appends an invalid path and then falls back to the default path (I mention this in this PR). I think the code for handling runners should probably also be cleaned up since it's not a very thorough implementation but it should allow me to add the 'sys-wine-current' in one line of code. https://github.com/bottlesdevs/Bottles/blob/eb96598ff13886dbf78b15f8f153fc0a837e48c0/bottles/backend/wine/wineserver.py#L32C1-L43C52 |
Adds a new runner option named sys-wine-current which will allow the bottle to automatically keep up with the current system version of wine installed.
Description
The code just adds the name of that option if a system installation of wine is detected, since any option name starting with "sys-" should just use the system paths/libraries.
Fixes #(4184)
Type of change