kmod: enable PIE for static builds#929
Open
piyush-jena wants to merge 1 commit into
Open
Conversation
Signed-off-by: Piyush Jena <jepiyush@amazon.com>
arnaldo2792
reviewed
May 13, 2026
| Subject: [PATCH] meson: add support for static builds | ||
|
|
||
| Signed-off-by: Piyush Jena <jepiyush@amazon.com> | ||
| [update to get PIE for static builds] |
Contributor
There was a problem hiding this comment.
You don't need the double sign-off. Also, can you explain why we couldn't do this before and now we can? Is this just a new finding?
Contributor
Author
There was a problem hiding this comment.
When I worked on it last time the objective was to get meson to build the exact same executables as automake (which was used before). I remember intentionally skipping PIE because "that would make it different". I found out about the existing issue recently.
I can't really comment on why it was harder to do earlier. The kmod contributors added PIE only after moving to meson. (kmod-project/kmod@6acdf06). I would assume meson just makes the process easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #394
Description of changes:
Testing done:
Mounted bottlerocket root partition locally
From admin container (had to
yum install -y checksec)nvidia-smishows the device is loaded (driver works)Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.