Skip to content

Add ability to get raw bytes of an archive member's path#36

Open
ethteck wants to merge 12 commits into
borisbrodski:masterfrom
ethteck:pathbytes
Open

Add ability to get raw bytes of an archive member's path#36
ethteck wants to merge 12 commits into
borisbrodski:masterfrom
ethteck:pathbytes

Conversation

@ethteck
Copy link
Copy Markdown

@ethteck ethteck commented Nov 18, 2020

The bytes can be then properly decoded to the correct string later on in Java. See the unit test for an example.

@ethteck
Copy link
Copy Markdown
Author

ethteck commented Nov 20, 2020

Hey @borisbrodski - I don't mean to nag you but I was wondering if there's anything further I can do to help get this in. Thanks for your cooperation with this :)

@borisbrodski
Copy link
Copy Markdown
Owner

Sorry for the delay. I'm totally busy learning new stuff for the new projects for a client (Deep learning, Python, React and NodeJS at the same time). :)

I very appreciate your contribution, it will be defensively merged. I just have to run tests on all platforms.

@borisbrodski
Copy link
Copy Markdown
Owner

Sorry for the huge delay. Are you still interested in this change? I have some questions about the code.

@ethteck
Copy link
Copy Markdown
Author

ethteck commented Jul 5, 2022

No worries! My employer would still appreciate this getting merged upstream if possible, I believe. I might have handled some of the windows api stuff incorrectly - not as familiar with that. But yeah, happy to answer any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants