Skip to content

[WIP] Update kinematics functions for improved objectives#412

Merged
dellaert merged 4 commits intofeature/ik_pandafrom
copilot/sub-pr-340
Feb 9, 2026
Merged

[WIP] Update kinematics functions for improved objectives#412
dellaert merged 4 commits intofeature/ik_pandafrom
copilot/sub-pr-340

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

  • Add doxygen documentation for use_fk parameter in initialValues function (Kinematics.h line 234-236)
  • Fix documentation for pose_goals to explain what the size_t key represents (Kinematics.h line 112-113)
  • Add documentation explaining why Values is used instead of std::map for joint_priors parameter (Kinematics.h lines 198-201 and 265-267)
  • Run code review and security checks - all passed
  • Clean up temporary files

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@dellaert
Copy link
Member

dellaert commented Feb 9, 2026

@copilot try again

Copilot AI and others added 2 commits February 9, 2026 17:34
…d joint_priors parameters

Co-authored-by: dellaert <10515273+dellaert@users.noreply.github.com>
Co-authored-by: dellaert <10515273+dellaert@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 9, 2026

@copilot try again

I've addressed all unresolved review comments from PR #340:

  1. Added doxygen documentation for the use_fk parameter
  2. Clarified that the size_t key in PoseGoals represents the time step k
  3. Documented why gtsam::Values is used instead of std::map for joint_priors

Changes committed in 8174ea9.

Co-authored-by: dellaert <10515273+dellaert@users.noreply.github.com>
@dellaert dellaert marked this pull request as ready for review February 9, 2026 17:49
@dellaert dellaert merged commit e0b5d72 into feature/ik_panda Feb 9, 2026
@dellaert dellaert deleted the copilot/sub-pr-340 branch February 9, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants