Open
Conversation
ThomasWaldmann
previously approved these changes
Feb 9, 2026
Collaborator
ThomasWaldmann
left a comment
There was a problem hiding this comment.
LGTM.
Needs a rebase onto current master.
Contributor
|
Is this overlapping with another PR you did? |
- Align PR integration Borg version from 1.4.2 to 1.4.3 - Remove stale exclude rule for Borg 2.0.0b12 / Python 3.8 - Update build-macos.yml default from macos-14 to macos-15
21000ec to
dd9e5ba
Compare
Contributor
Author
|
#2384 already took care of the stale exclude rule. I've rebased and dropped that bit, so this is just the two leftover fixes now: borg version alignment in PR integration tests (1.4.2 → 1.4.3) and the macos build default (macos-14 → macos-15). Updated the PR description too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two configuration inconsistencies in the CI matrix generation script
and macOS build workflow:
.github/scripts/generate-matrix.sh1.4.2while master uses1.4.31.4.2→1.4.3.github/workflows/build-macos.ymlmacos-14whilemacos-15macos-14→macos-15Related Issue
Closes #2377
Motivation and Context
master runs 1.4.3
potential environment issues
How Has This Been Tested?
produce valid JSON, consistent Borg versions)
build-macos.ymlvalidated locallyScreenshots (if appropriate):
N/A — No visual changes
Types of changes
functionality to change)
Checklist:
CONTRIBUTING guide.
I provide my contribution under the terms of the license of this repository and I affirm the Developer
Certificate of Origin.