Open
Conversation
gregjkal
approved these changes
Feb 20, 2026
Collaborator
gregjkal
left a comment
There was a problem hiding this comment.
Approved, with a handful of minor comments. I have some broader thoughts on efficiency, but will take those as future optimization opportunities.
850a4f4 to
7590a6d
Compare
Collaborator
Author
|
@gregjkal PR review responded to and adjusted - I'll leave this one to you to merge, it'll need to be run manually on the server anyway with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to ticket #2022.
Adds a new contribution app which records git commits, pr contributions, and issue contributions. The result ended up looking different to the design because email addresses were only available for commits.
For now there's a question around repos with multiple libraries. For commits we duplicate them which matches what the existing commit table does. For PR and Issue contributions they're on a per repo basis because there was no constraint issue there and no preexisting data.
With a github personal access token the management command takes up to 6 hours to run, which is 5 minutes of actual processing and 55 minutes of GraphQL rate limit sleep. That may be reduced with tokens which have higher access rates. This should be considered when setting up the celery task.
I've tried to optimize the calls as much as possible using Etags for commits and tweaking the GraphQL queries. Notes about this are documented with the queries.
Once the identity merging work is completed there'll need to be a change to allow users to claim identities.
This PR also fixes some issues with coverage tests.