Skip to content

Fix use two-iterator erase-remove in multiplexer::cancel to avoid UB #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
L0rentz wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −1
Open

Fix use two-iterator erase-remove in multiplexer::cancel to avoid UB #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/redis/impl/multiplexer.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ void multiplexer::cancel(std::shared_ptr<elem> const& ptr)
{
if (ptr->is_waiting()) {
// We can safely remove it from the queue, since it hasn't been sent yet
reqs_.erase(std::remove(std::begin(reqs_), std::end(reqs_), ptr));
reqs_.erase(std::remove(std::begin(reqs_), std::end(reqs_), ptr), std::end(reqs_));
} else {
// Removing the request would cause trouble when the response arrived.
// Mark it as abandoned, so the response is discarded when it arrives
Expand Down
Loading