Skip to content

Fix construction from negative infinity binary floats#1399

Merged
mborland merged 4 commits into
developfrom
1398
Jun 17, 2026
Merged

Fix construction from negative infinity binary floats#1399
mborland merged 4 commits into
developfrom
1398

Conversation

@mborland

Copy link
Copy Markdown
Member

Closes: #1398

@mborland mborland self-assigned this Jun 17, 2026
@mborland mborland added the Bug Something isn't working label Jun 17, 2026
@mborland mborland merged commit b55cb22 into develop Jun 17, 2026
72 of 76 checks passed
@mborland mborland deleted the 1398 branch June 17, 2026 20:22
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.4%. Comparing base (292399b) to head (0d99c84).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/decimal/decimal128_t.hpp 66.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1399     +/-   ##
=========================================
- Coverage     98.4%   98.4%   -0.0%     
=========================================
  Files          290     291      +1     
  Lines        23499   23530     +31     
  Branches      2069    2069             
=========================================
+ Hits         23118   23147     +29     
- Misses         381     383      +2     
Files with missing lines Coverage Δ
include/boost/decimal/decimal32_t.hpp 95.7% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal64_t.hpp 95.0% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal_fast128_t.hpp 95.7% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal_fast32_t.hpp 97.5% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal_fast64_t.hpp 97.6% <100.0%> (+0.1%) ⬆️
test/github_issue_1384.cpp 100.0% <ø> (ø)
test/github_issue_1398.cpp 100.0% <100.0%> (ø)
include/boost/decimal/decimal128_t.hpp 95.8% <66.7%> (-0.1%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292399b...0d99c84. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

convert from floating point (-inf) value results in decimal (inf) value

1 participant