[Feature]: Add metadataTab ui components - #5
Conversation
MonkeyDo
left a comment
MonkeyDo
left a comment
There was a problem hiding this comment.
Looks good from here!
A couple of details:
| __docformat__ = 'restructuredtext en' | ||
| class CalibbrePlugin(InterfaceActionBase): | ||
| name = "CaliBBre" | ||
| description = "A plugin for Integration with bookbrainz" |
There was a problem hiding this comment.
| description = "A plugin for Integration with bookbrainz" | |
| description = "Integration with the BookBrainz API" |
|
|
||
| cover_bytes = None | ||
| if isbn: | ||
| cover_url = f"https://covers.openlibrary.org/b/isbn/{isbn}-L.jpg" |
There was a problem hiding this comment.
Considering the image load quite slowly, I wonder if we should be using another size instead for a better user experience:
| cover_url = f"https://covers.openlibrary.org/b/isbn/{isbn}-L.jpg" | |
| cover_url = f"https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg" |
There was a problem hiding this comment.
Tested this.
Sharing the comparison.
( Although I did not notice any significant improvement in loading speed )
( Screenshots )
- L (66kb)
- M (29kb)
- S (2kb) ( ofc we will not use this :) )
|
Sorry, some comments should apply to PR #3 instead 🙈 |
MonkeyDo
left a comment
MonkeyDo
left a comment
There was a problem hiding this comment.
A few small requests, no notes apart from that 👍
There was a problem hiding this comment.
I think it would be nice to have an "Open in BookBrainz" button that would open the browser to the expected page
|
|
||
| def retranslate_search_panel(self, _translate): | ||
|
|
||
| for col, text in enumerate(["Name", "Authors", "Language", "BBID", "SortName"]): |
There was a problem hiding this comment.
I would expecrt "Sort name" here with the space and second word lowercase
|
|
||
| self.label_searchResults_metadataTab.setText(_translate("Dialog", "Search Results")) | ||
| self.pushButton_fetch_metadataTab.setText( | ||
| _translate("Dialog", "Fetch Book Metadata") |
There was a problem hiding this comment.
Let's keep the capitalization consistent across the board: "Fetch book metadata"
| _translate("Dialog", "No matching books found") | ||
| ) | ||
| self.label_searchingMetadata_metadataTab.setText( | ||
| _translate("Dialog", "Searching Metadata...") |
| item = self.tableWidget_metadataTab.horizontalHeaderItem(col) | ||
| item.setText(_translate("Dialog", text)) | ||
|
|
||
| self.label_searchResults_metadataTab.setText(_translate("Dialog", "Search Results")) |
| self.label_name_metadataTab.setText(_translate("Dialog", "Name:")) | ||
| self.label_data_name_metadataTab.setText(_translate("Dialog", "")) | ||
| self.label_sortname_metadataTab.setText(_translate("Dialog", "Sort Name:")) | ||
| self.label_data_sortname_metadataTab.setText(_translate("Dialog", "")) |
There was a problem hiding this comment.
You know, I wodner if the sort name should be displayed so prominently considering the available space.
I would suggest maybe it would be better to have it after the title in parenthesis:
"Name: A Voyage to Arcturus (Voyage to Arcturus, A)"
Any opinions?
There was a problem hiding this comment.
yeah it looks great :) .
Also it will be truncated to "..." if it overflows
2 participants
Note: please checkout PR-4 first, changes are made on top of that