Pass MSVC exception through SetUnhandledExceptionFilter#336
Open
nanoant wants to merge 1 commit intobombela:masterfrom
Open
Pass MSVC exception through SetUnhandledExceptionFilter#336nanoant wants to merge 1 commit intobombela:masterfrom
nanoant wants to merge 1 commit intobombela:masterfrom
Conversation
This restores ability to chain std::set_terminate handlers on Windows by passing MSVC C++ runtime exceptions using their 0xE06D7363 system code back to original handler that will later call backward-cpp's terminator. Without this other std::set_terminate handlers were blocked when using backward-cpp.
mgerhardy
added a commit
to vengi-voxel/vengi
that referenced
this pull request
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores ability to chain std::set_terminate handlers on Windows by passing MSVC C++ runtime exceptions using their
0xE06D7363system code back to original handler that will later call backward-cpp's terminator.Without this other
std::set_terminatehandlers were blocked when using backward-cpp.Accompanying example below. Running
test.exe exshows that custom termination handler is now effective and rethrowing prints proper stack trace.