Fix #159 - Use LinkedHashSet to store sets#161
Open
CheShianHung wants to merge 23 commits into
Open
Conversation
psybers
self-requested a review
October 11, 2017 20:50
psybers
requested changes
Oct 11, 2017
psybers
left a comment
psybers
left a comment
Member
There was a problem hiding this comment.
Anywhere the variable is declared, the type should be the more general type Set. Only when instantiated do we want a concrete type LinkedHashSet.
psybers
requested changes
Oct 12, 2017
psybers
approved these changes
Aug 15, 2019
psybers
approved these changes
Sep 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159