Map common import names to their package names - #531
Open
bubaizhanshen wants to merge 1 commit into
Open
Conversation
StantonMatt
reviewed
Jun 2, 2026
StantonMatt
left a comment
There was a problem hiding this comment.
I checked this branch locally. The mapping changes are consistent with the existing import-to-distribution override path, and the new test covers the four aliases directly.
Validation from a project-local Python 3.9 venv:
PYTHONPATH=. python -m unittest tests.test_pipreqs.TestPipreqs.test_get_pkg_names tests.test_pipreqs.TestPipreqs.test_get_pkg_names_maps_common_import_aliases-> 2 tests, OKPYTHONPATH=. python -m py_compile pipreqs/pipreqs.py tests/test_pipreqs.py-> OKpython -m flake8 tests/test_pipreqs.py-> OKgit diff --check origin/master...HEAD-> OK
Only local note: the unittest command emitted urllib3's LibreSSL warning from this macOS Python; it was not from this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #491. Addresses part of #360.
This maps common import names to their package names for
kafka,janitor,skimage, andsklearn, and adds regression coverage for those aliases.Checks:
python -m unittest tests.test_pipreqs.TestPipreqs.test_get_pkg_names tests.test_pipreqs.TestPipreqs.test_get_pkg_names_maps_common_import_aliasespython -m py_compile pipreqs/pipreqs.py tests/test_pipreqs.pyflake8 tests/test_pipreqs.pygit diff --check