Refactor code by removing internal ok variable#194
Merged
Conversation
phiwuu
added
the
internal
phiwuu
force-pushed
the
internal/source-manager-remove-ok-variable
branch
2 times, most recently
from
3c281ea to
b5e4d3b
Compare
Refactor method `register_file`: The internal variable `ok` represents an internal state that tracks the control flow of the try-except block. The variable is not needed after all, as we can directly return `True` or `False` in the appropriate control flows using early return. This refactoring simplifies code maintenance.
phiwuu
force-pushed
the
internal/source-manager-remove-ok-variable
branch
from
b5e4d3b to
624d6bd
Compare
Daniele143
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor method
register_file:The internal variable
okrepresents an internal state that tracks the control flow of the try-except block.The variable is not needed after all, as we can directly return
TrueorFalsein the appropriate control flows using early return.This refactoring simplifies code maintenance.