bluez.Device: Move fallbacks here from Base - #3242
Open
infirit wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I disagree with sonarcloud here. This is an error and having the exception logged helps. |
The fallbacks are for org.bluez.Device1 not everyting based on Base.
infirit
force-pushed
the
propertyfallbacks
branch
from
May 31, 2026 14:36
cd1b6de to
5d59165
Compare
|
Contributor
Author
|
Rebased and CI is clean. |
infirit
enabled auto-merge (rebase)
May 31, 2026 14:38
cschramm
reviewed
Jun 2, 2026
| return property.unpack() | ||
| elif name in self.__fallback: | ||
| return self.__fallback[name] | ||
| elif self._fallbacks is not None and name in self._fallbacks: |
Member
There was a problem hiding this comment.
is not None is redundant
Suggested change
| elif self._fallbacks is not None and name in self._fallbacks: | |
| elif name in self._fallbacks: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallbacks are for org.bluez.Device1 not everyting based on Base.