feat(a11y): make the deck keyboard and screen-reader navigable#4
Open
Reebz wants to merge 1 commit into
Open
Conversation
The deck was unusable by keyboard and screen-reader users: nav dots were non-focusable divs, inactive slides stayed in the accessibility tree, and slide changes were silent. Make dots real buttons with aria-current, mark inactive slides inert and aria-hidden, move focus to the active slide, and announce each change through a polite live region. Co-Authored-By: Leslie Barbara Knope (Claude Opus 4.8 (1M context)) <noreply@anthropic.com>
|
@Reebz is attempting to deploy a commit to the bluedusk's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The deck was not usable by keyboard or screen-reader users. Nav dots were non-focusable divs, inactive slides stayed in the accessibility tree, and slide changes were silent.
<button type="button">witharia-label="Go to slide N of M"andaria-currenton the active dot, so they take focus and activate on Enter and Space for free.inertandaria-hidden, so a screen reader reads only the active slide and Tab skips hidden controls.aria-live="polite"region.:focus-visiblering visible only for keyboard users, and an.sr-onlyutility for the live region.Mirrored into
assets/slides-runtime.jsand the inline runtime inreferences/html-template.md, including the.sr-onlyand focus styles, with the contract documented inreferences/presentation-layer.md.Test
Dependencies
Touches
slides-runtime.js, so it is cleanest to merge after the nav-input-hardening PR.Co-Authored-By: Leslie Barbara Knope (Claude Opus 4.8 (1M context)) noreply@anthropic.com