fix(runtime): harden navigation against overlays, scroll, and stray touches#3
Open
Reebz wants to merge 1 commit into
Open
fix(runtime): harden navigation against overlays, scroll, and stray touches#3Reebz wants to merge 1 commit into
Reebz wants to merge 1 commit into
Conversation
…ouches Navigation leaked through overlays, misread diagonal scroll, and stole horizontal scroll from wide code blocks, and touch swipes fired on vertical drags and flip-card taps. Add an overlay guard, axis-locked wheel and touch handling that respects scrollable targets, and a standalone replayActiveSlide() for restarting a slide's entry animations. Co-Authored-By: Leslie Barbara Knope (Claude Opus 4.8 (1M context)) <noreply@anthropic.com>
|
@Reebz is attempting to deploy a commit to the bluedusk's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Input handling that leaked while presenting and while viewing on touch devices.
goTo()early-returns when the skill's own.diagram-lightbox.activeis open or any[data-blocks-nav]:not([hidden])element is present, so arrow keys, wheel, and swipe no longer move the slide behind a modal. The marker also gives authors a hook for their own overlays..code-bodyscrolls instead of changing slides. It ignores sub-threshold deltas and navigates on the dominant axis only, which fixes the diagonal-scroll misread.replayActiveSlide(). A standalone public function that restarts a slide's staggered entry animations, leaving the existing next, prev, keyboard, and dot contract untouched.Every change is mirrored into both
assets/slides-runtime.jsand the inline runtime inreferences/html-template.md, andreplayActiveSlide()is documented inSKILL.mdandreferences/presentation-layer.md.Test
testing/fixtures/deck-overlay-and-codeblock.html(added) exercises the overlay block and the horizontal code-block scroll. A vertical scroll over a tall card and a two-finger gesture no longer navigate, and a deliberate horizontal swipe still does.Dependencies
Touches
slides-runtime.js, so it is cleanest to merge after the runtime null-guard PR.Co-Authored-By: Leslie Barbara Knope (Claude Opus 4.8 (1M context)) noreply@anthropic.com