fix(css): clear safe-area insets and honor reduced-motion on the Pro path#2
Open
Reebz wants to merge 1 commit into
Open
fix(css): clear safe-area insets and honor reduced-motion on the Pro path#2Reebz wants to merge 1 commit into
Reebz wants to merge 1 commit into
Conversation
…path Fixed bottom chrome sat under the iOS notch and home indicator because the viewport meta lacked viewport-fit=cover and the offsets ignored the safe area. Route the chrome offsets through env(safe-area-inset-bottom), which resolves to zero on desktop, so nothing moves there. Also add the prefers-reduced-motion block to the Pro path, where it was documented but absent, so the infinite particle, glow, and bob loops actually stop. Co-Authored-By: Leslie Barbara Knope (Claude Opus 4.8 (1M context)) <noreply@anthropic.com>
|
@Reebz is attempting to deploy a commit to the bluedusk's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Found while viewing a deployed deck on a notched phone.
viewport-fit=coverto the viewport meta, without whichenv(safe-area-inset-*)resolves to zero on notched iOS..progress-bar,.slide-counter, and.nav-hintsbottom offsets throughenv(safe-area-inset-bottom, 0)viacalc(), so notched devices clear the home indicator while desktop and non-notched layouts stay pixel-identical.@media (prefers-reduced-motion: reduce)block tocomponents.css. Reduced-motion is documented for the Pro path but absent from it. This stops the infinite particle, glow, and bob loops and shortens entrance transitions. It mirrors the existing block inviewport-base.css, extended withanimation-iteration-count: 1so the looping animations actually halt.references/html-template.mdabout where reduced-motion lives.A doc inconsistency worth a look
While here I noticed
SKILL.mdcallsviewport-base.cssmandatory for every deck (lines 55, 282, and 516), but the per-mode bullets (286 to 308) point the Pro path at a slide model that conflicts with it. I leftSKILL.mduntouched here to keep this PR small, and it is worth a separate clarification.Test
prefers-reduced-motion: reduce, particle, glow, and bob animations stop and entrance transitions are near-instant.Dependencies
Touches
components.css, so it is cleanest to merge after the runtime null-guard and100dvhPR.Co-Authored-By: Leslie Barbara Knope (Claude Opus 4.8 (1M context)) noreply@anthropic.com