Revamp repo tooling and pass CI on Node 24 - #14
Merged
Merged
Conversation
Update .nvmrc from 16 to 24 and regenerate package-lock.json accordingly.
Replace the hand-rolled CI_Checks.yml and setup-env composite action with the hemilabs reusable js-checks workflow, pinned by commit SHA so every underlying action is locked by hash. Switch deps:check to knip at the repo root: the per-package dependency-check scripts relied on a binary that was never installed. Add a knip.json for the monorepo and expose the fetch-plus-plus type declarations via a "types" field, both surfaced by the new check.
On Node 24, isomorphic-fetch resolves to the native global fetch (undici), which nock 13 cannot intercept, so the fetch-plus-plus tests hit the real network and failed. nock 14 intercepts undici, restoring all 6 tests.
Test only against Node 22 and 24.
There was a problem hiding this comment.
Pull request overview
This PR modernizes repository tooling so the monorepo can run checks and tests on newer Node versions, especially Node 24.
Changes:
- Updates the Node target to 24 and replaces the hand-rolled CI workflow with the reusable
hemilabsJS checks workflow. - Replaces per-package
dependency-checkscripts with a root-levelknipdependency check configuration. - Updates
nockand exposesfetch-plus-plusTypeScript declarations via the packagetypesfield.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.nvmrc |
Updates local/CI Node target to Node 24. |
.github/workflows/js-checks.yml |
Adds reusable JS checks workflow running on Node 22 and 24. |
.github/workflows/CI_Checks.yml |
Removes the previous custom CI workflow. |
.github/actions/setup-env/action.yml |
Removes the now-unused composite setup action. |
package.json |
Adds root deps:check, adds knip, and updates nock. |
knip.json |
Adds monorepo dependency-check configuration. |
packages/fetch-plus-plus/package.json |
Publishes TypeScript declarations through the types field. |
packages/promise-throttle-bucket/package.json |
Removes obsolete package-level deps:check. |
packages/promise-swr/package.json |
Removes obsolete package-level deps:check. |
packages/promise-stale-if-error/package.json |
Removes obsolete package-level deps:check. |
packages/promise-mem/package.json |
Removes obsolete package-level deps:check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gabmontes
approved these changes
May 29, 2026
arielmergen
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR kicks off a small revamp of the repo, with the first goal being to get CI checks passing again on a modern Node.
.nvmrc), the version CI and local development now target.js-checksworkflow, pinned by commit SHA so every underlying action is locked by hash. This replaces the hand-rolledCI_Checks.ymlandsetup-envcomposite action.deps:checkto knip at the repo root. The previous per-packagedependency-checkscripts relied on a binary that was never installed, so the check never actually ran. Added aknip.jsonfor the monorepo and exposed thefetch-plus-plustype declarations via atypesfield (both surfaced by the new check).fetch-plus-plustests pass on Node 24:isomorphic-fetchnow resolves to the native globalfetch(undici), which nock 13 couldn't intercept — tests were silently hitting the real network.With these changes the full pipeline (
format:check,lint,deps:check,test) passes locally on Node 22 and 24 (33 tests across all 6 packages).Process checklist
Metrics
Actual effort: 1h