Fix promise mem types - #11
Merged
Merged
Conversation
gabmontes
requested review from
gndelia,
leanazulyoro,
maxivarela and
mbonfoster
June 17, 2025 21:49
gabmontes
marked this pull request as ready for review
June 17, 2025 21:55
gabmontes
enabled auto-merge
June 17, 2025 21:55
gndelia
reviewed
Jun 17, 2025
Member
Author
|
@gndelia I don't think that was needed but I just updated the lockfile anyway. |
Contributor
true, but the next time someone run a |
gndelia
approved these changes
Jun 18, 2025
maxivarela
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property
resolverinpromise-memis optional! This silly bug was causing TS errors to show up.Process checklist
Metrics
Actual effort: 0.5h