Track Apache Arrow mimalloc allocations#943
Draft
pablogsal wants to merge 1 commit into
Draft
Conversation
1 task
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
- Coverage 92.41% 92.26% -0.16%
==========================================
Files 99 99
Lines 11787 11803 +16
Branches 430 430
==========================================
- Hits 10893 10890 -3
- Misses 894 913 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
godlygeek
reviewed
May 26, 2026
Comment on lines
+901
to
+905
| #ifdef MEMRAY_HAS_GHOST_STACK | ||
| if (d_fast_unwind) { | ||
| ghost_stack_dump_stats(); | ||
| } | ||
| #endif |
Contributor
There was a problem hiding this comment.
Looks like this was a rebase mistake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hook the
arrow_mi_malloc_aligned/arrow_mi_realloc_aligned/arrow_mi_freesymbols proposed in apache/arrow#41128 so memray can attribute Arrow's logical allocations instead of seeing only the underlying mmap arenas.Also re-resolves hook originals on module-cache invalidation so symbols defined in libraries loaded after tracker init (like libarrow.so) resolve before their GOT entries are patched.