Remove public relay signing key fallback - #6729
Open
jmecom wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jordan Mecom <jm@squareup.com>
jmecom
force-pushed
the
security/remove-public-relay-fallback-key
branch
from
August 24, 2026 22:25
3179fc1 to
ceb38fd
Compare
jmecom
marked this pull request as ready for review
August 24, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require
BUZZ_RELAY_PRIVATE_KEYon every relay startup and remove the shared public fallback key completely.For local development,
just bootstrapnow generates a random key once in the gitignored.envfile. Re-running bootstrap preserves that key, so relay-authored events retain the same identity across restarts. The local relay recipes reload.env, while isolated CI and E2E launchers pass explicit per-run keys.Startup fails immediately when the key is missing or invalid, before connecting to Postgres or Redis. Deployed relays continue to receive their stable key from the existing chart-managed secret.
Validated with:
./scripts/test-ensure-local-relay-key.shcargo test -p buzz-relay --bin buzz-relaycargo clippy -p buzz-relay --bin buzz-relay -- -D warningscargo fmt --all -- --checkshellcheck scripts/ensure-local-relay-key.sh scripts/test-ensure-local-relay-key.sh