Skip to content

fix(desktop): stabilize members dialog scrolling - #6670

Merged
wesbillman merged 1 commit into
mainfrom
scrolling-members-dialog
Aug 24, 2026
Merged

fix(desktop): stabilize members dialog scrolling#6670
wesbillman merged 1 commit into
mainfrom
scrolling-members-dialog

Conversation

@matt2e

@matt2e matt2e commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Keep virtualized member rows measurable by removing content-visibility: auto from the measured row subtree.
  • Use the member card's 60px baseline as the virtualizer estimate while retaining deferred rendering for eager search and archived-member lists.
  • Cover large rosters with a regression test that checks stable scroll extent across the list and verifies the final member remains reachable.

Related issue

None found.

Testing

  • just ci
  • pnpm -C desktop build:e2e
  • pnpm -C desktop exec playwright test tests/e2e/channels.spec.ts --grep 'members sidebar virtualizes large channel rosters' --repeat-each=5

Before

members-before.mov

After

members-after.mov

@matt2e
fix(desktop): stabilize members dialog scrolling
72589f9 
Signed-off-by: Matt Toohey <contact@matttoohey.com>
@matt2e
matt2e requested a review from a team as a code owner August 24, 2026 06:30
wesbillman
wesbillman reviewed Aug 24, 2026
View reviewed changes

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Verdict: no blocking findings.

Reviewed exact range 0720f5380ce8a6c050afac159f8462c06cd51ab5..72589f96ce00a648258289b199590e6482df53ca.

The change correctly separates eager member rows from virtualized rows: only search and archived results retain content-visibility: auto, while the virtualizer measures the real card subtree. The 60px initial estimate matches the card baseline and remains safe for variable-height agent rows because measureElement records their actual size. Profile, focus, menu, and archived disclosure semantics are unchanged.

Validation:

  • Focused large-roster Playwright regression passed 5/5 locally at exact HEAD after an exact-head E2E build.
  • Exact-head Desktop CI, smoke E2E, integration E2E, DCO, and release-candidate checks are green.
  • git diff --check passed.
  • The PR reports mergeable; a three-way merge-tree against current origin/main is conflict-free.

I found no evidence-backed correctness, interaction, accessibility, or regression-coverage defect in this change. This is a comment review, not an approval.

@wesbillman
wesbillman merged commit 72ba987 into main Aug 24, 2026
24 checks passed
@wesbillman
wesbillman deleted the scrolling-members-dialog branch August 24, 2026 15:18
tellaho added a commit that referenced this pull request Aug 24, 2026
@tellaho Carl
Merge remote-tracking branch 'origin/main' into tho/inline-chip-wrap
4cd4a3b 
* origin/main:
  fix(desktop): emit singular `mention` feed category so alerts route correctly (#6665)
  fix(mobile): recover stale and shuffled messages (#6691)
  feat(mobile): browse and join open channels (#6243)
  show mention counts in channel notifications (#6696)
  fix(desktop): hide selection formatting tray on composer right-click (#6683)
  fix(desktop): stabilize members dialog scrolling (#6670)
  fix(desktop): keep member runtime status off the UI thread (#6445)
  perf(desktop): persist channel heads, collapse thread reads and reply sends (#6572)
  Downgrade desktop Huddles to audio protocol v2 (#6610)
  Polish Huddle participant interactions (#6312)

Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
@yjc801 yjc801 mentioned this pull request Aug 24, 2026
Closed
brow added a commit that referenced this pull request Aug 24, 2026
@brow
Merge remote-tracking branch 'origin/main' into codex/mobile-push-not…
29edeeb 
…ifications-pr

* origin/main:
  fix(desktop): emit singular `mention` feed category so alerts route correctly (#6665)
  fix(mobile): recover stale and shuffled messages (#6691)
  feat(mobile): browse and join open channels (#6243)
  show mention counts in channel notifications (#6696)
  fix(desktop): hide selection formatting tray on composer right-click (#6683)
  fix(desktop): stabilize members dialog scrolling (#6670)
  fix(desktop): keep member runtime status off the UI thread (#6445)
  perf(desktop): persist channel heads, collapse thread reads and reply sends (#6572)
  Downgrade desktop Huddles to audio protocol v2 (#6610)
  Polish Huddle participant interactions (#6312)
  Downgrade mobile Huddles to audio protocol v2 (#6558)
  perf(desktop): make the Projects surface render-cheap (#6460)
  refactor(acp): clarify agent prompt sections (#6501)
  Add mobile Huddles voice MVP (#6056)
  feat(desktop-messages): keep agents addressed across messages (#6315)
  fix(desktop): remove Buzz entity link previews (#6512)

Signed-off-by: Tom Brow <tomb@block.xyz>

# Conflicts:
#	mobile/lib/features/channels/channels_provider.dart
#	mobile/lib/shared/auth/auth_provider.dart
#	mobile/lib/shared/community/community_provider.dart
#	mobile/test/shared/auth/auth_provider_test.dart
#	mobile/test/shared/community/community_provider_test.dart
#	scripts/mobile-worktree-overrides.sh
kursmark-sq added a commit to kursmark-sq/buzz that referenced this pull request Aug 24, 2026
@kursmark-sq
Merge remote-tracking branch 'origin/main' into agent/cmd-w-close
91a4dfb 
* origin/main: (90 commits)
  fix(desktop): bound thread /query and surface load errors, not false-empty (block#6447)
  fix(messages): route edits to the owning composer (block#6575)
  fix(mobile): join starter channels after accepting invite (block#5915)
  Add mobile profile editing (block#6583)
  fix(desktop): align jump-to-latest pill with composer height (block#6606)
  fix(desktop): emit singular `mention` feed category so alerts route correctly (block#6665)
  fix(mobile): recover stale and shuffled messages (block#6691)
  feat(mobile): browse and join open channels (block#6243)
  show mention counts in channel notifications (block#6696)
  fix(desktop): hide selection formatting tray on composer right-click (block#6683)
  fix(desktop): stabilize members dialog scrolling (block#6670)
  fix(desktop): keep member runtime status off the UI thread (block#6445)
  perf(desktop): persist channel heads, collapse thread reads and reply sends (block#6572)
  Downgrade desktop Huddles to audio protocol v2 (block#6610)
  Polish Huddle participant interactions (block#6312)
  Downgrade mobile Huddles to audio protocol v2 (block#6558)
  perf(desktop): make the Projects surface render-cheap (block#6460)
  refactor(acp): clarify agent prompt sections (block#6501)
  Add mobile Huddles voice MVP (block#6056)
  feat(desktop-messages): keep agents addressed across messages (block#6315)
  ...

Signed-off-by: Matt Kursmark <kursmark@squareup.com>

# Conflicts:
#	desktop/src/app/App.tsx
#	desktop/src/app/useCloseWindowShortcut.ts
michaelneale added a commit that referenced this pull request Aug 25, 2026
@michaelneale
Merge remote-tracking branch 'origin/main' into micspiral/mesh-0.76.0…
8cffb88 
…-rc3

* origin/main: (86 commits)
  Centralize replaceable event persistence (#6660)
  feat(workflows): discover trigger filter values (#6712)
  feat(desktop): simplify the message action rail (#6529)
  fix(desktop): restore icon-only remote marker (#6491)
  fix(ci): prevent poisoned Rust caches (#6618)
  docs(security): route reports through private advisories (#6728)
  fix(composer): wrap Buzz chip labels without orphaning icons (#6581)
  fix(desktop): bound thread /query and surface load errors, not false-empty (#6447)
  fix(messages): route edits to the owning composer (#6575)
  fix(mobile): join starter channels after accepting invite (#5915)
  Add mobile profile editing (#6583)
  fix(desktop): align jump-to-latest pill with composer height (#6606)
  fix(desktop): emit singular `mention` feed category so alerts route correctly (#6665)
  fix(mobile): recover stale and shuffled messages (#6691)
  feat(mobile): browse and join open channels (#6243)
  show mention counts in channel notifications (#6696)
  fix(desktop): hide selection formatting tray on composer right-click (#6683)
  fix(desktop): stabilize members dialog scrolling (#6670)
  fix(desktop): keep member runtime status off the UI thread (#6445)
  perf(desktop): persist channel heads, collapse thread reads and reply sends (#6572)
  ...
@adrienlacombe adrienlacombe mentioned this pull request Aug 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesbillman wesbillman wesbillman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matt2e @wesbillman