Repository navigation
Conversation
acd9791 to
c2ecba3
Compare
|
Rebased onto the latest No review comments on this PR. CI will verify the build and test gate. |
c2ecba3 to
c189bfc
Compare
🔐 Codex Security Review
|
|
Rebased onto the latest Still-needed assessment: No upstream commits in the 62-commit window address the same issue. This PR remains needed. Review requests: |
c189bfc to
9a8a456
Compare
|
Rebased onto current Conflict resolved: Still needed: No upstream commit addresses inspectable job result handoffs. The PR remains relevant. Verification:
|
9a8a456 to
e64ed87
Compare
Rebase and review — 2026-09-03Base commit: Accuracy review: Completed job results still reopen the full thread instead of showing a result handoff. |
e64ed87 to
0a98b96
Compare
Rebase and review update — Sep 3, 2026Rebased onto latest main ( Accuracy review: Main does not have job result handoff support — job lifecycle kinds 43001–43006 are not admitted to Mergeable status: Confirmed MERGEABLE on GitHub after force-push. |
0a98b96 to
d8917e3
Compare
Rebase pass — Sep 5, 2025Rebased onto current upstream main ( Rebase resultRebased cleanly onto current main. No conflicts. Still-needed assessmentChecked all 62 new main commits for overlap with this PR's topic. None obsoleted:
Verification
|
d8917e3 to
7aefa33
Compare
Rebase pass — Sep 9, 2026Rebased onto current upstream main ( Rebase resultRebased cleanly onto current main. No conflicts. Still-needed assessmentChecked all 8 new main commits for overlap with this PR's topic. None obsoleted. None of the 8 new main commits add job-result handoff UI. Verification
|
7aefa33 to
b6db2b2
Compare
Rebase pass — Sep 16, 2026Rebased onto current upstream main ( Rebase resultRebased cleanly onto current main. No conflicts. Still-needed assessmentNone of the 37 new main commits add job-result handoff UI. Verification
What was not doneNo local test suites were run. The rebase only repositions commits; conflict resolutions carry the same logical changes forward (CI will verify builds). |
BradGroux
left a comment
There was a problem hiding this comment.
Review refresh — 2026-10-02
Reviewed against current main 5a4b2d3d.
Verdict: Still needed. Current main has no JobResultPayload contract or equivalent structured job-result handoff.
Rebase check: All three commits rebase cleanly in a disposable detached worktree, but five touched core/SDK/relay files also changed upstream. The resulting contract needs focused core, SDK, CLI, relay admission, and desktop rendering verification before publication.
Static review: No actionable defect found. The payload parser fails closed to legacy rendering, builders bind results to requests, and all six lifecycle kinds are channel-scoped and covered by the PR's relay tests.
No branch update was pushed in this pass because updating the PR head would trigger the repository's pull_request GitHub Actions workflows, which this workstream is not authorized to trigger.
Co-authored-by: Brad Groux <bradgroux@hotmail.com> Signed-off-by: Brad Groux <bradgroux@hotmail.com> Signed-off-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
Co-authored-by: Brad Groux <bradgroux@hotmail.com> Signed-off-by: Brad Groux <bradgroux@hotmail.com> Signed-off-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
Signed-off-by: ScaleLeanChris <chris@scalelean.com> Signed-off-by: Brad Groux <bradgroux@hotmail.com> Signed-off-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
b6db2b2 to
85450c2
Compare
|
Still relevant on current Core/SDK/CLI library tests, 184 relay-ingest tests (14 ignored), 29 focused Desktop parse/render/layout tests, strict Rust all-target Clippy, typecheck, formatting, file-size, and diff checks passed. Postgres-dependent relay admission/integration and the complete native handoff journey remain unverified locally. Head: |
Make completed agent work inspectable from a structured kind 43004 handoff instead of reconstructing the entire thread. Add a versioned job-result payload, typed SDK builder,
buzz jobs handoff, channel-scoped relay admission for the existing job lifecycle, a Desktop result card, and a human-readable Home projection.The payload includes disposition, outcome, artifacts, verification, and blockers. Validate byte/item limits and unsafe references in Rust and Desktop. Require the payload's request ID to match the single signed reply tag. Keep legacy, malformed, unsupported, oversized, or tag-mismatched content on the existing Markdown fallback; ignore additive unknown fields in version 1.
Reject credential-bearing URLs and absolute local paths, including Windows drive/rooted/UNC forms, before exposing handoff references. Signed content is authoritative; schema/disposition tags are query hints.
Closes #2932.
Verification
Rebased onto
mainat2d289f720de0, preserving third-party authorship. Corrected the lazy import for the named card export and reconstructed the shared fallback with current Wave/video-review rendering, typography, agent prefix, and search behavior. Removed a duplicated CLI test attribute introduced by merging current coverage.Core/SDK/CLI library tests, 184 relay-ingest tests (14 ignored), 29 focused Desktop parse/render/layout tests, strict Rust all-target Clippy, Desktop typecheck/formatting, file-size, and diff checks pass. Postgres-dependent relay admission/integration and the complete native handoff journey were not exercised.
No scheduler, worker loop, approval system, workspace scanner, new HTTP endpoint, production dependency, or change to job acceptance/mention delivery is added.