Skip to content

Reformat repository into a python package to make it installable#1

Open
dafrose wants to merge 5 commits into
blochchainlab:masterfrom
dafrose:master
Open

Reformat repository into a python package to make it installable#1
dafrose wants to merge 5 commits into
blochchainlab:masterfrom
dafrose:master

Conversation

@dafrose
Copy link
Copy Markdown

@dafrose dafrose commented Oct 12, 2020

  • moved files around
  • some cosmetic changes for pep8 compliance
  • fixed python 3 compatibility in eddy_nlgc_mp.py (is this file still in use?)

Copy link
Copy Markdown
Collaborator

@gagdiez gagdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs was literally invented to have the possibility of having different levels of indentation. tabs should always be preferred over a fixed number of spaces.

By using tabs we allow customizations that are essential for people with visual impairment. Custom tab-widths might seem like an unnecessary thing to most, but some people rely on it - and we can not ignore that.

@dafrose
Copy link
Copy Markdown
Author

dafrose commented Oct 12, 2020

@gagdiez
PEP8 clearly states:

Spaces are the preferred indentation method.
Tabs should be used solely to remain consistent with code that is already indented with tabs.
Python 3 disallows mixing the use of tabs and spaces for indentation.
https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces

@dafrose
Copy link
Copy Markdown
Author

dafrose commented Oct 12, 2020

But thx for accepting. Does this mean the PR is accepted and can be merged? I honestly was not aware that anyone other than @mpaquette did maintain this repo :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants