Open
Conversation
dustinvtran
changed the title
dustinvtran
force-pushed
the
refactor/private
branch
2 times, most recently
from
e08f02d to
8c11d7e
Compare
dustinvtran
force-pushed
the
refactor/private
branch
2 times, most recently
from
1607d97 to
744e515
Compare
dustinvtran
force-pushed
the
refactor/private
branch
from
744e515 to
69c45ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes explicit which class members and methods are public during inference. In particular, we prepend any private methods with underscores. We also prepend all class members with underscore and use the
@propertydecorator as a getter method. This follows TensorFlow convention.