[PM-38153] feat: Add Passport add/edit screens#2763
Conversation
Surface synced Passport ciphers in the vault list and search, gated behind the pm-32009-new-item-types feature flag, mirroring the Driver's License integration: passport group filtering, id-card icon, type-section row, and the Copy passport number overflow action. Add/Edit/View screens remain stubbed pending PM-38153/PM-38154.
Adds the add/edit SwiftUI surface for Passport items: 13 fields in the Figma order, with passport number and national identification number as hidden fields with reveal toggles, and date of birth, issue date, and expiration date rendered read-only (long localized display, raw ISO round-trip) pending the shared DateFieldPicker (PM-38360). Exposes Passport in the add-item picker gated behind the newItemTypes flag, injects ConfigService into VaultRepository for that gating, wires the state to SDK PassportView round-trip, and shows the add-item FAB on the Passports group screen.
Wire passport through both response-model BitwardenSdk.Cipher inits so a synced passport's fields survive sync-to-store and populate the edit form.
57081fb to
6c00a53
Compare
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds the Passport add/edit SwiftUI surface (13 fields in design order), wires the state through Code Review DetailsNo findings — the change follows established patterns, preserves zero-knowledge guarantees (passport data flows through the SDK; no sensitive data is logged or persisted in plaintext), gates the feature behind |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vault/pm-38152-ios-passport-vault-list #2763 +/- ##
==========================================================================
+ Coverage 86.94% 86.96% +0.01%
==========================================================================
Files 1896 1901 +5
Lines 180095 180903 +808
==========================================================================
+ Hits 156592 157318 +726
- Misses 23503 23585 +82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-38153
📔 Objective
Adds the add/edit screen for Passport vault items: all passport fields in design order, with passport number and national identification number as hidden fields with reveal toggles, and date of birth, issue date, and expiration date shown as read-only localized dates. Passport is available in the add-item picker behind the
newItemTypesfeature flag and round-trips through the SDK on save.📸 Screenshots
Edit passport
Add passport