[PM-38144] feat: Add bank account add/edit screens#2757
Conversation
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR (PM-38144) wires up the Bank Account add/edit screens, mirroring the established Card/Driver's License pattern across 25 files. Code Review DetailsNo findings. Notes on patterns intentionally preserved (not findings):
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
==========================================
- Coverage 87.85% 86.92% -0.94%
==========================================
Files 1712 1901 +189
Lines 166702 180569 +13867
==========================================
+ Hits 146463 156958 +10495
- Misses 20239 23611 +3372 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Implement the add/edit SwiftUI surface for Bank Account items (BA-4), mirroring the existing Card pattern: ten fields in the Figma order with an account-type picker and reveal toggles for the account number, PIN, and IBAN. Wire the new state through the shared AddEditItem flow, the state<->SDK round-trip, and the add-item picker (gated behind the newItemTypes feature flag), and restore the Bank accounts group's add-item button.
734a65b to
e540865
Compare
🎟️ Tracking
📔 Objective
Add the add/edit screen for Bank Account items. The form renders all 10 fields — bank name, name on account, account type (picker), account number, routing number, branch number, PIN, SWIFT code, IBAN, and bank contact phone — with reveal toggles on the account number, PIN, and IBAN. Saving round-trips through the SDK, and Bank Account is now selectable from the add-item picker and the Bank accounts group's add button, gated behind the
newItemTypesfeature flag.📸 Screenshots
Add
Edit