[PM-27139] feat: Adds TOTP form view along with action, effect, processor & state.#2753
[PM-27139] feat: Adds TOTP form view along with action, effect, processor & state.#2753morganzellers-bw wants to merge 8 commits into
Conversation
github-actions
Bot
added
the
app:password-manager
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
==========================================
- Coverage 87.90% 86.96% -0.95%
==========================================
Files 1719 1903 +184
Lines 167804 180905 +13101
==========================================
+ Hits 147507 157319 +9812
- Misses 20297 23586 +3289 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Warning @morganzellers-bw Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details. |
|
Warning @morganzellers-bw Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details. |
morganzellers-bw
changed the title
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds a TOTP autofill test scenario to the BWTH (Bitwarden Test Harness) following the established Action/Effect/Processor/State/View pattern used by the sibling Code Review DetailsNo findings. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| /// Effects that can be processed by a `TOTPAutofillFormProcessor`. | ||
| /// | ||
| enum TOTPAutofillFormEffect: Equatable {} |
There was a problem hiding this comment.
🎨 If there's no effect then you don't need this file and you can pass Void to the StateProcessor. Check e.g. ExpiredLinkProcessor.
| /// The title of the screen. | ||
| var title: String = Localizations.totpAutofillForm |
There was a problem hiding this comment.
🎨 As far as I can see the title doesn't change so I think we can move the localization directly to the view.
There was a problem hiding this comment.
⛏️ I think we should be adding the .accessibilityIdentifier as in the main apps in case QA then wants to automate this.
| Text(Localizations.xColonY(Localizations.totpCode, store.state.totpCode)) | ||
| .styleGuide(.body) |
There was a problem hiding this comment.
🤔 ♻️ Perhaps not for this PR as I think this is following the same structure as in other views but I'm not sure if we should keep duplicating the values in here as it's the same as the above TextField for TOTP code. Do you think duplicating this here in "view" mode could be useful for something else?
3 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27139
📔 Objective
Add an input form to test TOTP autofill from Bitwarden
📸 Screenshots
Expand