[PM-38027] feat: Match local URI domain by port in iOS#2708
Open
xrvk wants to merge 4 commits into
Open
Conversation
|
|
Collaborator
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
xrvk
changed the title
Apply domain-match port disambiguation for localhost/IP URIs in iOS autofill matching, mirroring clients behavior while keeping regular domains port-agnostic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Detect IPv6 literals locally in CipherMatchingHelper since the shared isIPAddress regex only handles IPv4, and add tests for IPv6 port mismatch and multi-URI fallback after a localhost/IP port mismatch rejection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xrvk
force-pushed
the
xrvk/fix-local-ip-domain-port-match-ios
branch
from
0920057 to
61470bf
Compare
morganzellers-bw
added
the
app:password-manager
Contributor
|
Hi @xrvk! These changes look good and I approved the workflows to run. I'll keep an eye on this one and let you know if I need any updates; thanks for the contribution! 👍 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 1719 1719
Lines 167804 167887 +83
=======================================
+ Hits 147507 147584 +77
- Misses 20297 20303 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
morganzellers-bw
removed
app:password-manager
morganzellers-bw
changed the title
morganzellers-bw
added
app:password-manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
When multiple local services share the same IP or localhost host but run on different ports, domain matching can select the wrong login. This change adds iOS parity with the clients fix by requiring matching ports for domain matching only when both URIs are localhost or IP addresses.
Changes:
DefaultCipherMatchingHelperdomain matching to reject localhost/IP matches when ports differ..domain.CipherMatchingHelperTestscoverage for local IP and localhost port cases, plus a regression test that regular domains still match across different ports.📸 Screenshots
N/A - no UI changes.