Rename deprecated killOthers to killOthersOn

[Hinton]

🎟️ Tracking

📔 Objective

Resolves the deprecation warning we get when running electron.

open-cli-tools/concurrently@c31bb87

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @Hinton's task —— View job

---

Code Review Complete ✓

• Read the changed files
• Run bitwarden-code-reviewer agent
• Post comprehensive review feedback

---

Review Summary

Overall Assessment: ✅ APPROVE

This PR correctly addresses the deprecation warning from the concurrently library by migrating from the deprecated killOthers property to killOthersOn.

---

Detailed Findings

Changes Verified

Files Modified:

• apps/desktop/scripts/nx-serve.js:40
• apps/desktop/scripts/start.js:37

Change Applied:

- killOthers: ["success", "failure"],
+ killOthersOn: ["success", "failure"],

Review Checklist

👍 Migration Correctness: The property rename from killOthers to killOthersOn is correct per the concurrently library deprecation

👍 Consistency: Both files updated identically with the same property name and value

👍 Value Preservation: The array value ["success", "failure"] remains unchanged, maintaining existing behavior (kills other processes on success or failure)

👍 Completeness: No other instances of the deprecated killOthers property exist in the codebase

👍 Version Compatibility: Project uses concurrently 9.2.x which supports the new killOthersOn property

👍 Scope Appropriateness: Changes limited to development scripts only - no impact on production code

---

Conclusion

This is a straightforward, correct implementation of a library deprecation fix. The change resolves the Electron deprecation warning without altering functionality. No issues identified.

Recommendation: Ready to merge ✅

---

[github-actions]

Checkmarx One – Scan Summary & Details – 2c00d787-7796-4210-aa89-d4166ff8522c

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.71%. Comparing base (ec5a54f) to head (c18231c).
⚠️ Report is 15 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17856   +/-   ##
=======================================
  Coverage   41.70%   41.71%           
=======================================
  Files        3571     3571           
  Lines      103769   103769           
  Branches    15613    15613           
=======================================
+ Hits        43281    43288    +7     
+ Misses      58653    58646    -7     
  Partials     1835     1835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.