Skip to content

Conversation

@neuronull
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29287

📔 Objective

In #17815 , we reverted the changes that surfaced an unexpected interaction (and exposed a bug in the build script) in order to unblock the release.

This PR does the following:

  • reverts the revert (re-apply's the code changes made in Desktop Native compile debug builds with debug log level #17357)
  • fixes a bug in the build.js script- we weren't propagating the "release" mode flag correctly in the cross-platform case , it was always taking release mode explicitly.
  • changed the build-desktop workflow to only pass in release mode when the workflow is called by an upstream workflow (which we do for releases). The other two cases are manual trigger of workflow, or a PR trigger, in which case we want debug builds.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@neuronull neuronull self-assigned this Dec 5, 2025
@neuronull neuronull added the desktop Desktop Application label Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Logo
Checkmarx One – Scan Summary & Detailsab562abf-ab07-41a3-885e-db9ab94d0f17

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.69%. Comparing base (3efa7b1) to head (f3531cf).
⚠️ Report is 18 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/desktop_native/napi/src/lib.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17845      +/-   ##
==========================================
+ Coverage   41.66%   41.69%   +0.03%     
==========================================
  Files        3568     3571       +3     
  Lines      103441   103906     +465     
  Branches    15572    15618      +46     
==========================================
+ Hits        43102    43328     +226     
- Misses      58507    58739     +232     
- Partials     1832     1839       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TARGET: musl
# Note: It is important that we use the release build because some compute heavy
# operations such as key derivation for oo7 on linux are too slow in debug mode
# operations such as key derivation for oo7 on linux are too slow in debug mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! Just to make sure, did you test that snap / flatpak don't re-encounter the regression from being built in debug mode? (If not please add it to the QA notes, just want to make sure we don't have the bug re-appear).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling that out! I will make a note to verify that 👍

@neuronull
Copy link
Contributor Author

resolved a merge conflict

@neuronull neuronull closed this Dec 10, 2025
@neuronull neuronull deleted the neuronull/reapply-debug-builds-debug-log-level branch December 10, 2025 15:33
@neuronull
Copy link
Contributor Author

closed this to rename the branch to associate with the ticket, see #17908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Desktop Application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants