-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Re-apply desktop native debug log level debug builds and fix build workflow #17845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17845 +/- ##
==========================================
+ Coverage 41.66% 41.69% +0.03%
==========================================
Files 3568 3571 +3
Lines 103441 103906 +465
Branches 15572 15618 +46
==========================================
+ Hits 43102 43328 +226
- Misses 58507 58739 +232
- Partials 1832 1839 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| TARGET: musl | ||
| # Note: It is important that we use the release build because some compute heavy | ||
| # operations such as key derivation for oo7 on linux are too slow in debug mode | ||
| # operations such as key derivation for oo7 on linux are too slow in debug mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this! Just to make sure, did you test that snap / flatpak don't re-encounter the regression from being built in debug mode? (If not please add it to the QA notes, just want to make sure we don't have the bug re-appear).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for calling that out! I will make a note to verify that 👍
|
resolved a merge conflict |
|
closed this to rename the branch to associate with the ticket, see #17908 |

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-29287
📔 Objective
In #17815 , we reverted the changes that surfaced an unexpected interaction (and exposed a bug in the build script) in order to unblock the release.
This PR does the following:
build.jsscript- we weren't propagating the "release" mode flag correctly in thecross-platformcase , it was always taking release mode explicitly.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes