Fix model_formats arg missing in cli - #942
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the training interface to use model_formats consistently and exposes that option in the CLI so users can select one or more trained-model output formats.
Changes:
- Rename/align the training API parameter from
model_formattomodel_formatsand pass it through totrain_model. - Update the allowed
TRAINED_MODEL_OUTPUT_FORMATSto includedetached(and removeboth) to match the implementation. - Add
--model_formatsto the CLI training command and validate values viaTRAINED_MODEL_OUTPUT_FORMATS.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| birdnet_analyzer/train/core.py | Renames the training wrapper arg to model_formats and forwards it to train_model. |
| birdnet_analyzer/config.py | Updates the TRAINED_MODEL_OUTPUT_FORMATS literal set to include detached. |
| birdnet_analyzer/cli.py | Adds --model_formats argument for the training CLI and ties choices to config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+891
to
+895
| "--model_formats", | ||
| nargs="+", | ||
| default=["tflite"], | ||
| choices=get_args(TRAINED_MODEL_OUTPUT_FORMATS), | ||
| help="Model output format(s). One or more of 'tflite', 'raven', 'detached'.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.