Adding the required flag to request bodies, matching servant semantics#49
Open
lepsa wants to merge 1 commit intobiocad:masterfrom
Open
Adding the required flag to request bodies, matching servant semantics#49lepsa wants to merge 1 commit intobiocad:masterfrom
lepsa wants to merge 1 commit intobiocad:masterfrom
Conversation
|
Note that there's PR haskell-servant/servant#1347 to no longer ignore |
|
Hi! Is there anything we can do to move this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
servant-openapi3isn't setting the required flag for marking request bodies as required. This PR updates theReqBody'instance to add that flag.Request bodies are optional by default
https://swagger.io/docs/specification/describing-request-body/
Servant requires request bodies to be Required.
https://hackage.haskell.org/package/servant-0.20/docs/Servant-API-ReqBody.html