Skip to content

fix: remove encodeURI for image links #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bingryan merged 1 commit into from
Jul 2, 2026
Merged

fix: remove encodeURI for image links #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,18 +344,18 @@ export async function tryCopyImage(
imageLinks[index][7 - imageLinks[index].length];

// decode and replace the relative path
let imageLink = decodeURI(urlEncodedImageLink).replace(
/\.\.\//g,
""
);
if (imageLink.contains("|")) {
imageLink = imageLink.split("|")[0];
let imageLink = "";
try {
imageLink = decodeURIComponent(urlEncodedImageLink).replace(/\.\.\//g, "");
} catch (e) {
console.warn(`Unable to decode URI: ${urlEncodedImageLink}`);
imageLink = urlEncodedImageLink.replace(/\.\.\//g, "");
}

const fileName = path.parse(path.basename(imageLink)).name;
const imageLinkMd5 = plugin.settings.fileNameEncode
? md5(imageLink)
: encodeURI(fileName);
: fileName;
const imageExt = path.extname(imageLink);
const ifile = plugin.app.metadataCache.getFirstLinkpathDest(
imageLink,
Expand Down Expand Up @@ -857,10 +857,13 @@ export async function tryCopyMarkdownByRead(
imageLinks[index][7 - imageLinks[index].length];

// decode and replace the relative path
let imageLink = decodeURI(urlEncodedImageLink).replace(
/\.\.\//g,
""
);
let imageLink = "";
try {
imageLink = decodeURIComponent(urlEncodedImageLink).replace(/\.\.\//g, "");
} catch (e) {
console.warn(`Unable to decode URI: ${urlEncodedImageLink}`);
imageLink = urlEncodedImageLink.replace(/\.\.\//g, "");
}
// link: https://help.obsidian.md/Linking+notes+and+files/Embedding+files#Embed+an+image+in+a+note
// issue: #44 -> figure checkout: ![[name|figure]]
if (imageLink.contains("|")) {
Expand All @@ -869,7 +872,7 @@ export async function tryCopyMarkdownByRead(
const fileName = path.parse(path.basename(imageLink)).name;
const imageLinkMd5 = plugin.settings.fileNameEncode
? md5(imageLink)
: encodeURI(fileName);
: fileName;
const imageExt = path.extname(imageLink);
// Unify the link separator in obsidian as a forward slash instead of the default back slash in windows, so that the referenced images can be displayed properly

Expand Down
Loading